Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rights property #72

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Add rights property #72

merged 3 commits into from
Oct 3, 2022

Conversation

kirkkwang
Copy link
Contributor

@kirkkwang kirkkwang commented Oct 1, 2022 •
edited
Loading

It seems the rights property was not getting set. According to the pres 3 specs, rights should be a string and not an array.

  • add rights property to v3 manifests
  • assure rights is a string
  • disable rubocop PerceivedComplexity

image

cjcolvar
cjcolvar reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
It would be nice if you could add a test to show rights appears in the manifest and that it is always a string and not an array.

@kirkkwang
Copy link
Contributor Author

Yes definitely, can do!

@kirkkwang
Copy link
Contributor Author

@cjcolvar Here are the tests i came up with, ready for your review

@cjcolvar cjcolvar force-pushed the add-rights-property branch from 7c863a2 to 6c4220a Compare October 3, 2022 20:18
cjcolvar
cjcolvar approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjcolvar cjcolvar merged commit 0c014de into main Oct 3, 2022
@cjcolvar cjcolvar deleted the add-rights-property branch October 3, 2022 20:19
@cjcolvar cjcolvar mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkkwang @cjcolvar