Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID property to Annotation #66

Merged
merged 3 commits into from
May 4, 2022
Merged

Add ID property to Annotation #66

merged 3 commits into from
May 4, 2022

Conversation

masaball
Copy link
Contributor

@masaball masaball commented May 3, 2022

Presentation 3.0 requires all annotations to have an HTTP(S) URI, contained in an id property. This PR adds URI generation for annotations and tests to ensure that the annotation id property is populated.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! I just had a small question about the id generated for annotations.

lib/iiif_manifest/v3/manifest_builder/content_builder.rb Outdated Show resolved Hide resolved
cjcolvar
cjcolvar previously approved these changes May 4, 2022
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@masaball masaball merged commit f4d16cb into main May 4, 2022
@masaball masaball deleted the anno_id branch May 4, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants