-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling pairtree paths for Fedora 6 in Sirenia #6804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files ±0 17 suites ±0 2h 18m 36s ⏱️ + 1m 6s Results for commit 478f3c4. ± Comparison against base commit 26fdf09. This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
randalldfloyd
force-pushed
the
f6_pairtree_ids
branch
from
June 3, 2024 21:31
8d427fb
to
5889deb
Compare
dlpierce
force-pushed
the
f6_pairtree_ids
branch
from
July 10, 2024 19:56
5d8a538
to
478f3c4
Compare
dlpierce
approved these changes
Jul 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR depends on changes in this Valkyrie PR.
Fedora 6.5 now supports automatic creation of "pairtree" IDs, which means that identifiers are stored in a hashed directory structure to avoid excessive child nodes directly in the root node.
However, unlike Fedora 4 where this was the default behavior, it has to be enabled via options in 6.5. Since doing so requires configuring both the count and length of the pairtree algorithm, it needs to be configurable in the Valkyrie Fedora adapters so that both sides match.
This PR sets the
fcrepo
image to run 6.5 in the Sirenia compose file and sets JVM runtime options to enable automatic creation of pairtree paths. The corresponding values are then set in the Valkyrie adapter initialization so that ID to URI translations are correct.For example, if an ID of
AaBbCcDd
in Fedora was created under the root node as/Aa/Bb/Cc/Dd/AaBbCcDd
, then setting count and length to 4 and 2 in the Fedora adapters ensures that the same path will be calculated and returned.Note that the configuration above is not required for pairtree paths to work correctly in Fedora 4, and automatic pairtree creation is not supported under Fedora 5 or Fedora 6 < 6.5.