Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results alternative layouts missing styling (Gallery, Masonry) - Bootstrap 4 #5721

Open
eporter23 opened this issue Jun 22, 2022 · 4 comments

Comments

@eporter23
Copy link
Contributor

Descriptive summary

Hyrax 3.x branches using Bootstrap 4 appear to have missing styling for non-list search result layouts.

Rationale

Design continuity and usability

Expected behavior

When a user clicks on one of the non-default layouts, the search results should be presented in an alternative way according to the design pattern for that layout option.

Gallery (nurax example)

Screen Shot 2022-06-22 at 12 51 00 PM

Masonry (nurax example)

Screen Shot 2022-06-22 at 12 51 11 PM

Slideshow (nurax example)

Screen Shot 2022-06-22 at 12 59 37 PM

Actual behavior

Thumbnails are missing, and content blocks are not well delineated from each other. The slideshow option is also missing guidance text above the thumbnails ("Select an image to start the slideshow"), and the modal window is unstyled.

Gallery

Screen Shot 2022-06-22 at 12 53 02 PM

Masonry

Screen Shot 2022-06-22 at 12 53 14 PM

Slideshow

Screen Shot 2022-06-22 at 12 58 52 PM

Steps to reproduce the behavior

  1. Go to the homepage and hit Go in the search box to produce a large results list
  2. In the search results page, click on one of the non-list options such as Gallery, Masonry, or slideshow and observe the layout

Related work

Link to related tickets or prior related work here.

@rjkati
Copy link

rjkati commented Oct 4, 2022

testing blocked by #5888

@jlhardes
Copy link
Contributor

#5888 is closed and this should be testable on nurax-dev

@jlhardes
Copy link
Contributor

On nurax-dev with Hyrax 4 beta2, Gallery view is better (there are boxes around each item so better delineated) but thumbnails still missing.

Masonry view looks better and is all thumbnails like it was before.

Slideshow view seems to have better thumbnail view but still missing "Select an image to start the slideshow" instruction text.

@rjkati rjkati added this to the 4.x Series milestone Oct 31, 2022
@rjkati
Copy link

rjkati commented Feb 21, 2023

Retested on nurax-dev (hyrax 4.0.0.beta2) and behavior is still as described in #5721 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants