-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Match catalog search results match to Hyrax #2344
Conversation
Test Results 3 files ±0 3 suites ±0 17m 58s ⏱️ -26s Results for commit 89a755c. ± Comparison against base commit d6892bf. This pull request removes 43 and adds 44 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
c6cc1e2
a8f4ebc
to
c6cc1e2
Compare
@@ -43,6 +43,6 @@ | |||
description: "Show General Login Link at Top Right of Page." | |||
|
|||
feature :treat_some_user_inputs_as_markdown, | |||
default: true, | |||
default: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feature was brought over from PALs specifically, i don't think it should be a default for ALL hyku
This commit will along the look of the catalog search results page to look closer to the way Hyrax looks. The problem stems from the markdown feature. For plain text it adds a `<p>` tag which has a margin bottom. I think the best thing to do is turn it off for default and any tenant that is currently using it should turn it back on.
c6cc1e2
to
89a755c
Compare
Summary
💄 Match catalog search results match to Hyrax
89a755c
This commit will along the look of the catalog search results page to
look closer to the way Hyrax looks. The problem stems from the
markdown feature. For plain text it adds a
<p>
tag which has a marginbottom. I think the best thing to do is turn it off for default and any
tenant that is currently using it should turn it back on.
Screenshots
Before
After
From PG Nurax