Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix "Sort by: Published Date" #2316

Merged
merged 2 commits into from
Sep 10, 2024
Merged

🐛 Fix "Sort by: Published Date" #2316

merged 2 commits into from
Sep 10, 2024

Conversation

sjproctor
Copy link
Collaborator

Issue:

This commit fixes a bug in the ability to sort works by "Published date", "Upload date", and "Title" in the catalog search page and the collection show page reported in Adventist Knapsack.

Adds sorting to Solr doc in HykuIndexing module.

Ascending sort:
image
Descending sort:
image

@samvera/hyku-code-reviewers

This commit fixes a bug in the ability to sort works by "Published
date", "Upload date", and "Title" in the catalog search page and the
collection show page.

Ref:
- scientist-softserv/adventist_knapsack#185
@sjproctor sjproctor added bug patch-ver for release notes labels Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 21s ⏱️ -42s
2 034 tests ±0  1 984 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 061 runs  ±0  2 009 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit 2846f44. ± Comparison against base commit 83b2afe.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 07623e6b-58a3-4426-a44c-c21695618ad4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 1eeeee8b-cf82-4daa-9a73-7c0252acc44b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read d7b57580-f197-423f-89c9-451e7f2d3cc1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c435c0f0-174e-41ba-9934-3b90f4c4506b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3a3171b9-1ede-44fa-960d-75bc31d9077f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 9f079e64-773d-4215-ad8d-6bb0c2de940c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a4c89d1d-2252-4b28-966a-4e126843b02f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3d228320-09e5-46b6-8eff-cf9be9d94d07
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy e12ba6f4-8344-4954-b059-1638e1a1ba35
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c5899f50-7f39-494c-9e1a-650472f199fe
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy ce5d4b1b-2539-448c-9b1c-668c5283ad28
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 61a8323c-3216-4272-929a-50e6ed1bb32c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 218c4b42-1aad-48fd-bafd-2f1efa2a076f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 40b7031c-d1ae-4656-9123-290f25d1fb78
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy d03ac22b-1011-4f54-b705-a7a69b0d550b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit df7e560e-bbc6-46bd-aeb8-2598bf4c712a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read b7a855ee-d709-4929-8c0a-2c921faa893d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 7b6101a6-53b1-499b-bf2d-e836654a63a6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 5a5cb035-4463-48ec-bcaa-8f9b98589bc7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 21674c31-afb4-4fc2-8411-7f0dd3dd6e39
…

♻️ This comment has been updated with latest results.

This commit adds a guard clause to the `SortTitle` model to fix failing
tests due to a nil value being assigned to `@title` on initialization.

Ref:
- scientist-softserv/adventist_knapsack#185
@sjproctor sjproctor merged commit ca5f702 into main Sep 10, 2024
8 checks passed
@sjproctor sjproctor deleted the fixes-sort-by-actions branch September 10, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants