Contribute back OER and ETD work types from Hyku Commons #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will bring over all the new relevant files from Hyku Commons over to Hyku. This does not include any additional general locale yml files such as config/locales/hyrax.en.yml or config/locales/en.yml quite yet because they need to be examined.
This module is needed for the application to boot up because it is being called by OER and ETD.
This will add the OER and ETD to the translations. We would still need to run translations for all the other languages.
The `curation_concern.human_readable_type` call in the Hyrax's `app/views/hyrax/base/new.html.erb` now comes from Valkyrie: ```rb GenericWorkResource.method(:human_readable_type) => #<Method: GenericWorkResource(Hyrax::Resource).human_readable_type() /usr/local/bundle/bundler/gems/hyrax-151fb0d38339/app/models/hyrax/resource.rb:49> ``` These overrides will display them as OER and ETD instead of Oer and Etd. Ref: - https://github.com/samvera/hyrax/blob/151fb0d38339e12eabdf99ce9d0b1a0f07685fd5/app/views/hyrax/base/new.html.erb#L3
This will bring in terms from Hyku Commons, primarily used by the OER and ETD work types.
We add the new terms in the `CatalogController` from Hyku Commons
This commit adds the OER authorities from Hyku Commons
This commit will address the spec failures from bringing in OER and ETD.
Test Results 3 files ± 0 3 suites ±0 17m 36s ⏱️ +58s Results for commit d26120c. ± Comparison against base commit e5e6fee. This pull request removes 27 and adds 301 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ShanaLMoore
previously approved these changes
Jun 5, 2024
The locale files were in locales/locales, this commit will move it up a directory.
ShanaLMoore
dismissed
their stale review
The team has decided to complete the transaction work before merging in this code.
This was referenced Jun 5, 2024
These were originally miseed in the initial move over.
1 task
Currently the adding of a related version works however we still need to figure out removing.
This commit will add functionality to the OER transaction of adding custom relations to OER works. The js had to be altered because it was sending an object to the backend which then adds `[object Object]` to the OER work and not the actual id.
laritakr
approved these changes
Jun 10, 2024
|
Adding a Blocked label - hold off on merge until we cut a 6.0.0 release |
|
Removing blocked label. As discussed with Rob, cc @kirkkwang if you don't see a risk, feel free to merge this in instead of waiting for v6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Bring over new relevant files from Hyku Commons
67ce76d
This commit will bring over all the new relevant files from Hyku Commons
over to Hyku. This does not include any additional general locale yml
files such as config/locales/hyrax.en.yml or config/locales/en.yml quite
yet because they need to be examined.
🚧 Add
OrderMetadataValuesmodule for boot up4f7584f
This module is needed for the application to boot up because it is being
called by OER and ETD.
🚧 Add OER and ETD to translations
f508bc5
This will add the OER and ETD to the translations. We would still need
to run translations for all the other languages.
🚧 Make OER and ETD display in all caps
29c77b6
The
curation_concern.human_readable_typecall in the Hyrax'sapp/views/hyrax/base/new.html.erbnow comes from Valkyrie:These overrides will display them as OER and ETD instead of Oer and Etd.
Ref:
🚧 Add OER and ETD to factories
aa80dcf
🚧 Reconcile scholarly_show show
13483fb
🚧 Bring in terms from Hyku Commons
8e4fd3b
This will bring in terms from Hyku Commons, primarily used by the OER
and ETD work types.
🚧 Modify
CatalogController79e1180
We add the new terms in the
CatalogControllerfrom Hyku Commons🚧 Add OER authorities
04d6609
This commit adds the OER authorities from Hyku Commons
🚧 Add OER and ETD to wings
c38539a
🚧 Add _attribute_rows for etds
9efa8ad
🚧 Bring over
RelatedMembershipsJob560eeb6
✅ Fix specs
09ca0fe
This commit will address the spec failures from bringing in OER and ETD.
🧹 Move locale files to appropriate dir
4a1df66
The locale files were in locales/locales, this commit will move it up a
directory.
🧹 Bring over more partials for OER
54e7fb5
These were originally miseed in the initial move over.
🚧 Turn the OER Actor into a Transaction
eb77743
Currently the adding of a related version works however we still need to
figure out removing.
🎁 Make OER transaction functional
d26120c
This commit will add functionality to the OER transaction of adding
custom relations to OER works. The js had to be altered because it was
sending an object to the backend which then adds
[object Object]tothe OER work and not the actual id.