Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Hyrax 5 upgrade additional specs #2067

Merged
merged 13 commits into from
Dec 19, 2023

Commits on Dec 18, 2023

  1. 🧹 More spec & controller fixes

     Ref scientist-softserv/hykuup_knapsack#55
    
     - Contact form controller and pages controller duplicate some of the
     homepage controller behavior, so corresponding fixes are needed.
     - Update collections factory and collection_ability_spec to match hyrax
     and stop calling `.gid` on a collection_type.
     - Adjust permission_template_form_spec to adjust for removal of method
     `reset_access_controls!` and add a few new expectations instead.
    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f1aae1b View commit details
    Browse the repository at this point in the history
  2. 🧹 Begin work on Roles Service

    Working with Permission Templates has changed, requiring an adjustment
    to both logic and specs.
    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b67df4e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d847c0 View commit details
    Browse the repository at this point in the history
  4. Rubocop fixes

    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    16408e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    59aafd7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fff9bf3 View commit details
    Browse the repository at this point in the history
  7. Revert Rubocop changes

    Caused spec failure in roles_service_spec.
    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    02781ee View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    da06c93 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cc8c971 View commit details
    Browse the repository at this point in the history
  10. 🧹 Stanford import specs

    We have plans to remove the Stanford import logic, but for now, this
    handles the specs that were failing, in an attempt to get CI to pass.
    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a73a0eb View commit details
    Browse the repository at this point in the history
  11. Merge branch 'hyrax-5-upgrade'

    Merge into hyrax-5-upgrade-additional-specs
    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e1b6062 View commit details
    Browse the repository at this point in the history
  12. Make Rubocop happy

    laritakr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    41a9a1e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Fix typo

    laritakr committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5d52f3b View commit details
    Browse the repository at this point in the history