-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Hyrax 5 upgrade additional specs #2067
Merged
Merged
Commits on Dec 18, 2023
-
🧹 More spec & controller fixes
Ref scientist-softserv/hykuup_knapsack#55 - Contact form controller and pages controller duplicate some of the homepage controller behavior, so corresponding fixes are needed. - Update collections factory and collection_ability_spec to match hyrax and stop calling `.gid` on a collection_type. - Adjust permission_template_form_spec to adjust for removal of method `reset_access_controls!` and add a few new expectations instead.
Configuration menu - View commit details
-
Copy full SHA for f1aae1b - Browse repository at this point
Copy the full SHA f1aae1bView commit details -
Working with Permission Templates has changed, requiring an adjustment to both logic and specs.
Configuration menu - View commit details
-
Copy full SHA for b67df4e - Browse repository at this point
Copy the full SHA b67df4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d847c0 - Browse repository at this point
Copy the full SHA 2d847c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16408e3 - Browse repository at this point
Copy the full SHA 16408e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59aafd7 - Browse repository at this point
Copy the full SHA 59aafd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fff9bf3 - Browse repository at this point
Copy the full SHA fff9bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02781ee - Browse repository at this point
Copy the full SHA 02781eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for da06c93 - Browse repository at this point
Copy the full SHA da06c93View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc8c971 - Browse repository at this point
Copy the full SHA cc8c971View commit details -
We have plans to remove the Stanford import logic, but for now, this handles the specs that were failing, in an attempt to get CI to pass.
Configuration menu - View commit details
-
Copy full SHA for a73a0eb - Browse repository at this point
Copy the full SHA a73a0ebView commit details -
Merge branch 'hyrax-5-upgrade'
Merge into hyrax-5-upgrade-additional-specs
Configuration menu - View commit details
-
Copy full SHA for e1b6062 - Browse repository at this point
Copy the full SHA e1b6062View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41a9a1e - Browse repository at this point
Copy the full SHA 41a9a1eView commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5d52f3b - Browse repository at this point
Copy the full SHA 5d52f3bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.