Accessibility changes #1813
Merged
Accessibility changes #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds: * ability to add alternate text for images added via Appearance admin menu. * use of alternate text for main page logo * use of alternate text via title attribute for main page banner image * missing reindex jobs (referenced when adding default images) * default logo view (pulled up from hyrax) to allow use of alt text
orangewolf
approved these changes
Jul 7, 2022
orangewolf
added a commit
that referenced
this pull request
Jul 7, 2022
* Use main docker images for zookeeper and solr for development. M1 compatible images are not available by Bitnami and emulated solr is unstable. This allows development on M1 Macs without preventing development on other platforms. * Update .env fix solr password * update gemfile, temp disable hyrax-doi * rename migrations so hyrax wont keep trying to create duplicates, add new migrtions * UV install * add tinymce * remove Solrizer usage and mv solr/config to solr/conf * uv upgrade missing files * file by file update to 3.4.0 of app directory * rubocopin * bring doi gem back * env fix * env fix * rubocop * work through depreciations * use a m1 compatible selenium image and begin fixing feature specs * feature sync * solr config dir * Update edit.html.erb_spec.rb * Update solr_endpoint_spec.rb * update specs * Update fcrepo_endpoint.rb * Update fcrepo_endpoint_spec.rb * fix uglifier precompile check_volumes issue during docker-compose build * Update Gemfile * Update Gemfile * revert changes to config/features as they are already defined by and inherits from hyrax * fix no thumbnail and uv rendering issue * Remove stray references to uglifier Uglifier was replaced by terser. * fix helm deploy for new helm version, bump version tag to 4.1 * small typo * remove guard that prevents the search tenant from creating collection types * added required fields for User form for email and password. And removed the unnecessary hint text for password * bulkrax on by default, can still be disabled from environment variabel * work in progress: updated proprietor spec and modified required fields for global user form * removed WIP test for proprietor spec and instead created a test for the email and password validation in the user model spec * rubocop fix: replace should with is_expected.to * Accessibility changes (#1813) Adds: * ability to add alternate text for images added via Appearance admin menu. * use of alternate text for main page logo * use of alternate text via title attribute for main page banner image * missing reindex jobs (referenced when adding default images) * default logo view (pulled up from hyrax) to allow use of alt text * Add alt text for collection banner (#1814) * Add alt text for collection banner Resolves ticket https://gitlab.com/notch8/utk-hyku/-/issues/60 * Remove trailing spaces * Able to remove Current Account Administrators (#1817) * changed variable to fit convention better, fixed keep_emails array * Empty-Commit * Fix modal functionality for collection public show (#1819) `Add to collection` button is now functional. Also removes duplicated count of items under title. * update schema with bulkrax enabled (#1821) * udpate to fix the way #fetch evaluates env variables (#1820) Co-authored-by: Shana <[email protected]> Co-authored-by: Shana Moore <[email protected]> Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: selamhabteab <[email protected]> Co-authored-by: LaRita Robinson <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #utk-hyku #54
Adds:
@samvera/hyku-code-reviewers