-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I161 import collection resources #933
I161 import collection resources #933
Commits on Mar 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60b1e69 - Browse repository at this point
Copy the full SHA 60b1e69View commit details -
🚧 WIP: Import Collection Resource
A user should be able to import a collection resource. In this commit, we are able to successfully import and create collection resources. From the console we can see the collection formed relatioships with works, but the frontend's count and display shows 0 relationships. Additionally, we are unable to re run the importer without receiving errors on the collection entry. TODO: specs, refactor, Issue: - scientist-softserv/hykuup_knapsack#161
Configuration menu - View commit details
-
Copy full SHA for ce76e1f - Browse repository at this point
Copy the full SHA ce76e1fView commit details
Commits on Mar 8, 2024
-
Merge branch 'hyrax-4-valkyrie-support' into i161-import-collection-r…
…esources * hyrax-4-valkyrie-support: Adding index to schema ♻️ Reworking structure ♻️ Remove constant
Configuration menu - View commit details
-
Copy full SHA for 13ac5fa - Browse repository at this point
Copy the full SHA 13ac5faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 686a6ef - Browse repository at this point
Copy the full SHA 686a6efView commit details -
Merge branch 'hyrax-4-valkyrie-support' of github.com:samvera-labs/bu…
…lkrax into hyrax-4-valkyrie-support
Configuration menu - View commit details
-
Copy full SHA for 7efcdfb - Browse repository at this point
Copy the full SHA 7efcdfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d0695c - Browse repository at this point
Copy the full SHA 9d0695cView commit details -
refactor #conditionally_destroy_existing_files
This refactor was necessary because even though klass == ImageResource, which inherits from Valkyrie::Resouce through it's chain, klass === Valkyrie::Resource was returning false.
Configuration menu - View commit details
-
Copy full SHA for 1a007db - Browse repository at this point
Copy the full SHA 1a007dbView commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1afc94f - Browse repository at this point
Copy the full SHA 1afc94fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ab31b6 - Browse repository at this point
Copy the full SHA 4ab31b6View commit details -
Revert "WIP - try to import filesets with valkyrie resources"
This reverts commit 4ab31b6.
Configuration menu - View commit details
-
Copy full SHA for ceaa192 - Browse repository at this point
Copy the full SHA ceaa192View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 70cbfa2 - Browse repository at this point
Copy the full SHA 70cbfa2View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for def27d3 - Browse repository at this point
Copy the full SHA def27d3View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c0886d3 - Browse repository at this point
Copy the full SHA c0886d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for aedb868 - Browse repository at this point
Copy the full SHA aedb868View commit details
Commits on Mar 15, 2024
-
Merge branch 'hyrax-4-valkyrie-support' into i161-import-collection-r…
…esources * hyrax-4-valkyrie-support: Addressing TODO and minor refactoring ♻️ Favor Bulkrax.object_factory and add fault tolerance
Configuration menu - View commit details
-
Copy full SHA for c0dcd74 - Browse repository at this point
Copy the full SHA c0dcd74View commit details -
i162 - import valkyrie works with filesets (#936)
* Revert "WIP - try to import filesets with valkyrie resources" This reverts commit 4ab31b6. * WIP * WIP - try to import filesets with valkyrie resources * 🚧 WIP: get filesets to import via bulkrax x valkyrie * 🎉 WIP: filesets to imports via bulkrax x valkyrie There's still a lot to clean up here, but the import is successful in this commit. * 💄 rubocop fixes * uncomment #get_s3_files call and add collections to configuration * Update object_factory.rb * ♻️ Move method and remove single instance definition I'm unclear why we were defining methods on the conf instance; especially given that these exist on the configuration. With this refactor, we're favoring using the Configuration object as the container. * Revert changes due to refactor coming in from main * address errors post big refactor * Refactoring for consistent method signatures Also avoiding setting an unused instance variable * 🐛 remove passing user to work_resource add_file_sets and save merge to strategies Importing a CSV of valkyrie works, collections, files and relationships is working at this point 🎉 * 🎁 Adding a new transaction step to handle different association * ♻️ Extract update_index method to object factory * ♻️ Extract object factory method * ♻️ Extract add_resource_to_collection method * ♻️ XIT out the mockery and stubbery of a spec * ♻️ Extract method publish and add_child_to_parent_work * ♻️ Rename method as it's not conditional Yes, it is conditional but it operates on arrays that could be empty. * Remove add to collection step * 🐛 Fix publish parameter mismatch * Removing custom transaction container. We weren't using it * Favor keyword args instead of hashes * 💄fixing typo * 🎁 Add update_collection to valkyrie object factory * 💄 endless and ever appeasing of the coppers --------- Co-authored-by: Jeremy Friesen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d0b096b - Browse repository at this point
Copy the full SHA d0b096bView commit details