Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨: add sensor entity for the volume of the soundbar #9

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

samuelspagl
Copy link
Owner

@samuelspagl samuelspagl commented Dec 14, 2023

Improvements for Samsung Soundbar Component - Add Volume Sensor & Resolve Media Player Issue

Description:

This merge-request adds new functionality as well as fixes a minor bug.

  1. New sensor entity added (Missing sensor for Volume Level #8)
  2. Disabled extra_state_attributes to correctly display available sources/soundmodes in the media_player configuration. ([BUG]: media_player not showing source and sound mode #11)

These improvements provide better functionality and user experience for Samsung soundbar integration with Home Assistant via the SmartThings API. Your feedback is appreciated!

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ha-samsung-soundbar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 3:31pm

@Headkillah
Copy link

Sensor is present, but the value is not quite correct or is apparently calculated differently. For example: In the SmartThings integration, the volume level is displayed as 6%, but your integration shows me a volume level of 20. If I now set it to 7%, for example, the level in your integration is 23.333333333 :D And unfortunately the sensor is not updated immediately, there is a time delay of approx. 10 seconds.

Previously the sensor was displaying the scaled amount applied to the slider / number (between 0 and 1). Now it is displaying the raw value.
@samuelspagl samuelspagl merged commit 30ef090 into main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants