Add additional validation for CONF_ENTRY_MAX_VOLUME value in the setup process to be greater than zero #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p process to be greater than zero
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # CHANGELOG.md # custom_components/samsung_soundbar/manifest.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Add additional validation for CONF_ENTRY_MAX_VOLUME value in the setup process to be greater than zero
This PR closes #19 by adding an additional validation to the
CONF_ENTRY_MAX_VOLUMEint value.Instead of just checking whether an int was provided, it will also check weather this int is between
1and100with a default value of100.Changelog:
Added
intprovided forCONF_ENTRY_MAX_VOLUMEisgreater than
1and lower than100. This will make sure that a division by zero cannot happen.100toCONF_ENTRY_MAX_VOLUME