Remove -lhts
from Libs.private
in the pkg-config file.
#1852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
htslib.pc.in
specifies-lhts
in both theLibs
and theLibs.private
fields. This causes problems when using HTSlib from vcpkg, because vcpkg merges the latter field with the former, resulting inLibs: "-L${libdir}" -lhts "-L${libdir}" -lhts -lhtscodecs "-L${prefix}/lib" -lm -lpthread
. This causes CMake to remove the first-lhts
, which causes link errors because of undefined symbols from htscodecs.This PR fixes this by removing
-lhts
fromLibs.private
. According to my understanding of pkg-config the duplication in bothLibs
andLibs.private
is redundant either way.Validated locally.