New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Makefile dependencies and other minor fixes #1653

Merged

jkbonfield merged 2 commits into samtools:develop from jmarshall:misc54

Jul 19, 2023

Member

jmarshall commented Jul 19, 2023

A few missed Makefile changes from recent PRs.
Add const to avoid a warning when zlib is configured (via -DZLIB_CONST) to be more const-correct than is the default:

hts.c:335:25: warning: assigning to 'unsigned char *' from 'const Bytef *' (aka 'const unsigned char *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
                last_in = zs.next_in;

jmarshall added 2 commits

July 19, 2023 23:53


          Add missing Makefile dependencies [minor]

b2d5d0b


          Make last_in a pointer to const [minor]

727efe1

Zlib can be configured such that zs.next_in is a pointer to const.

jkbonfield merged commit 6285a68 into samtools:develop

Contributor

jkbonfield commented Jul 19, 2023

Thanks for this and the Samtools patch John.

jmarshall deleted the misc54 branch

July 19, 2023 22:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet