Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CURLINFO_CONTENT_LENGTH_DOWNLOAD_T for newer libcurl #1572

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

daviesrob
Copy link
Member

The older CURLINFO_CONTENT_LENGTH_DOWNLOAD has been deprecated, and is now causing warnings to be printed on distributions that have moved on to the latest libcurl versions. CURLINFO_CONTENT_LENGTH_DOWNLOAD_T was officially added in curl 7.55.0.

The older CURLINFO_CONTENT_LENGTH_DOWNLOAD has been deprecated,
and is now causing warnings to be printed on distributions that
have moved on to the latest libcurl versions.

CURLINFO_CONTENT_LENGTH_DOWNLOAD_T was officially added in
curl 7.55.0.
@daviesrob
Copy link
Member Author

Updated to use LIBCURL_VERSION_NUM. Sadly CURL_AT_LEAST_VERSION() doesn't exist in old curl include files (like those in CentOS 7).

@whitwham whitwham merged commit c37268c into samtools:develop Mar 1, 2023
@daviesrob daviesrob deleted the content_length branch March 1, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants