Fix gmake 4.4 "pattern recipe did not update peer target" warnings #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an upcoming change in how GNU make will handle pattern rules with multiple targets, GNU make 4.4 warns when pattern recipies don't update all targets listed. See https://lists.gnu.org/archive/html/help-make/2022-10/msg00020.html for more information. Such a case existed in bcftools' Makefile in a rule intended to make either .dll or .cygdll targets depending on the value of the PLUGIN_EXT variable. As PLUGIN_EXT could also be .so (handled by another rule) the easiest solution is to spilt the single rule into two, each having a single pattern target.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an upcoming change in how GNU make will handle pattern rules with multiple targets, GNU make 4.4 warns when pattern recipes don't update all targets listed. See https://lists.gnu.org/archive/html/help-make/2022-10/msg00020.html for more information.
Such a case existed in bcftools' Makefile in a rule intended to make either
.dllor.cygdlltargets depending on the value of thePLUGIN_EXTvariable. AsPLUGIN_EXTcould also be.so(handled by another rule) the easiest solution is to spilt the single rule into two, each having a single pattern target.