Publish using GitHub releases #4
Conversation
Use Github releases to publish binaries instead of committing them.
Remove binaries from the repository, as they are being distributed using releases instead.
Fails the CI build if no files are found to release.
Tar doesn't like it when the input directory changes, and this prevents that from happening.
|
@CoffeeCoder1 I get what you're doing here but the Godot asset library integrates with the git repo itself. So, this PR would prevent the asset library from consuming this plugin as the binaries would be missing. Also, most Godot people are not super git people. They'll just download all the files of the repo and expect it to work. |
This reverts commit 51429b8.
I see. I figured there was probably a reason why it was that way, but I just didn't know what it was. I'm thinking a solution could just be to add back the automated commits but also keep the releases, since they are still a pretty good way to organize things in the repo and they make manual installs a bit easier. |
The Godot asset library reads from the repo, so this step is necessary for the asset library to work.
|
What's the need for the release publishing? Do you have some other project that can only grab the binaries from a github release feed? @CoffeeCoder1 |
|
@samsface I don't really have any specific use, this is more of just an enhancement than anything. It should make downloading earlier releases and manually installing a bit easier, but I'd imagine that anyone who wants to do a manual install probably already knows how to download a git tag (I think one of the main workflows where this would be useful would be a command-line only workflow, which I'd imagine most Godot users aren't using). If you don't want to merge this that's fine, this was more of a proposal than anything. |
|
@samsface I just got around to creating an Asset Library account just to see what options are available, and it looks like we may actually be able to point it at a release URL by just selecting the |
Use GitHub releases to distribute binaries instead of committing them to the repository. A new release will be created by the CI workflow when a tag is pushed to the repository.