This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Added a list of static drives #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 15, 2020 18:19
Need to build a static function for model
Have to work on the CSS for the list
Cleaned up App.tsx Made some base components Started using hooks for the drives list
0xjohnnycagewins
approved these changes
Jan 17, 2020
|
|
||
| export const App: React.FC = () => { | ||
| return ( | ||
| <div className="App"> |
| @@ -0,0 +1,38 @@ | |||
| .App { | |||
There was a problem hiding this comment.
all filename should be in lowercase. Also when I said a base css I meant reset css:
https://necolas.github.io/normalize.css/
Comment on lines
+17
to
+28
| <Container {...props}> | ||
| {drives.current.map((drive: Drive) => ( | ||
| <DriveSummaryComponent | ||
| key={drive.id} | ||
| imageUrl={drive.imageUrl} | ||
| brand={drive.brand} | ||
| model={drive.model} | ||
| isShuckable={drive.isShuckable} | ||
| /> | ||
| ))} | ||
| </Container> | ||
| ); |
There was a problem hiding this comment.
Ideally, you would want to show a loading here if loaded is not true
| import styled from 'styled-components'; | ||
| import { Box } from 'view/component/generic/box-component'; | ||
|
|
||
| export const Column = styled(Box)` |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.