Update storybook #27
Update storybook #27
Conversation
This is now down automatically with presets just by defining the addon.
For an unknown reason, using the dayjs().add() method causes the story to not appear. I don't know what causes this but it fails completely if used. The .subtract() works fine so let's just use that
This doesn't appear to be used.
|
Just as a general comment, the last pull request I made with multiple commits was ultimately squashed and committed as one commit rather than merged. Don't know if this is a standard convention but it was quite confusing to see this happen as the detail in the individual commits was lost. IMO merging the branch (possibly with --no-ff) maintains a better history but I'm sure this is generally down to personal preference :-) Hope you're well? Cheers! |
There was a problem hiding this comment.
For what it's worth, I found out why dayjs().add() was an issue. It's due to an upstream bug which although marked as closed, it's just been marked as a duplicate. This workaround here seems like a valid approach for now.
| @@ -21,16 +21,12 @@ | |||
| "rangePicker", | |||
| "datePicker" | |||
| ], | |||
| "peerDependencies": { | |||
| "react": "^17.0.1", | |||
There was a problem hiding this comment.
Please build this package and link it and use it to another react project , you will be get some error like this, I think we should remain peerDependencies
There was a problem hiding this comment.
Ahh perhaps I misunderstood the docs... They suggested adding dev deps which I incorrectly assumed meant peerDeps weren't needed. Keeping them as both should work fine I guess... Will have a play later.
There was a problem hiding this comment.
Ahh, Sorry Maybe I was wrong, Please have a look at this;
I had double react version problem at the beginning of this package, when I was using react in dev deps, I search a lot then some guys suggest me to using in the pear deps. after the new version, it has not any problem after install it in the project.
|
Hey Thanks for you PR. I'm feeling good, Thanks. |
This is an attempt to update story book to the latest version. Comments welcome.
Description
I updated my dev environment to npm 7 and ran into problems with storybook build so attempted to fix this up. I suspect the changes could all be avoided just by using
npm install --legacy-peer-depswhich I ultimately had to use anyway but I figure these changes will be needed eventually anyway.Sadly, there are a bunch of problems that still remain (namely that this project requires react 17 and storybook is sadly still stuck requiring react 16 due to it's use of @reach/router. There are plans afoot to fix this, but in the mean time I still had to use
npm install --legacy-peer-depsto get a working build.In Storybook 6, addon-knobs has been deprecated but it still works for now. It should ultimately be migrated to addon-controls
Motivation and Context
I wanted this to work with latest npm. Failed and still had to use
--legacy-peer-depsbut upgrade still worked as a result.How Has This Been Tested?
I've tested this with npm, not used yarn. I was able to build the storybook and run it directly. I've not tried anything else related to release or building of the project.
Other than that, this was latest npm/node packages from npmsource DNF repository running in a CentOS 8 container.
Types of changes