Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2608: multiple caption tracks for the same language are not available #2668

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #2608: multiple caption tracks for the same language are not available #2668

wants to merge 3 commits into from

Conversation

gaskeo
Copy link

@gaskeo gaskeo commented Apr 28, 2023 •
edited
Loading

Link to related issue: #2608

Summary of proposed changes

Add

  • captions.setNode method. This method can set caption track by its node.

Change

  • captions.update method in src/js/captions.js:152 firstly checks currentTrackNode and calls setNode if currentTrackNode provided. If captions don't have currentTrackNode node, update method calls the setLanguage method.

Demo from issue:
https://codepen.io/emmitrin/pen/dyjjYKr

Fixed demo:
https://codepen.io/gaskeo/pen/abRwjpZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaskeo