Vimeo private videos: check for hash in src and add as a param #2322
Conversation
|
Hi @Frosch, I ran into the same problem with the private Vimeo videos, and tested your PR in our project. Some things I noticed: your code breaks the player when no source is set, for example: |
| } else { | ||
| hash = parseHash(source) | ||
| } | ||
| const hashParam = (!!hash) ? {h: hash} : {} |
There was a problem hiding this comment.
I think this can just be const hashParam = hash ? { h: hash } : {}?
* check for hash in src and add as a param * Enable different methods of passing hash
|
Is there timeline when it will go to release? |
|
I’ll try and jump on tonight and get a release out. There’s just a SASS change that needs some testing.
Sorry for the delay,
Sam
… On 6 Oct 2021, at 4:13 pm, vkwc ***@***.***> wrote:
Is there timeline when it will go to release?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Is it available now on master ? |
It's in 3.6.9 |
Link to related issue (if applicable)
#2321
Summary of proposed changes
As Vimeo now expects a given hash as a url-parameter
?h={hash}for newly uploaded private videos, I added some code for basic checking whether the given src-url contains the private hash, extracting it and adding it as a parameter to the iframe, if needed.'Basic' as in, you might want to make this more sophisticated: currently I just strip the src-url, but adding a separate option for vimeo-src or something might be preferred. Also this might be put into some checks whether the user has a business-/pro-account, as otherwise he can't have private videos anyway.
I can change this PR accordingly, if you need me to :)
This currently works as a workaround for us, as you have to do nothing different when using plyr (don't have to split the embed-url by yourself etc.)