obfuscation is now turnoffable #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lablans
requested changes
May 20, 2023
| ```bash | ||
| RETRY_COUNT = "32" | ||
| ``` | ||
|
|
||
| The default maximum number of retries for beam and blaze healthchecks is 32. | ||
|
|
||
| To disable the count obfuscation, set the env. variable `DO_NOT_OBFUSCATE`. |
There was a problem hiding this comment.
Please give values for on / off.
Consider using a positive variable (negations are confusing)
There was a problem hiding this comment.
It doesn't work with boolean.
clap-rs/clap#1649
Do you want it to be a string?
There was a problem hiding this comment.
Surprising but then I'm fine with it
| @@ -42,6 +42,10 @@ struct CliArgs { | |||
| #[clap(long, env, value_parser)] | |||
| blaze_url: Uri, | |||
|
|
|||
| /// Should the results not be obfuscated | |||
| #[clap(long, env, value_parser)] | |||
There was a problem hiding this comment.
Don't you want to set default value == false (meaning "yes, obfuscate?)
negations are confusing
There was a problem hiding this comment.
When the parameter is not present, it is false, no default needed
src/main.rs
Outdated
| true => cql_result | ||
| }; | ||
|
|
||
| dbg!(cql_result_new.clone()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.