Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more Reducible Collections Counted #2052

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Make more Reducible Collections Counted #2052

merged 1 commit into from
Sep 16, 2024

Conversation

alexanderkiel
Copy link
Member

Before some reducible collections like from the iterators namespace and such created by the with-open-coll macro did not implement Counted. So they could not directly counted and instead had to be converted into a vector first.

Needed by #1382

Before some reducible collections like from the iterators namespace and
such created by the with-open-coll macro did not implement Counted. So
they could not directly counted and instead had to be converted into a
vector first.

Needed by #1382
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (7a8d388) to head (a80b1c1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2052      +/-   ##
==========================================
- Coverage   95.00%   94.94%   -0.07%     
==========================================
  Files         325      325              
  Lines       19974    19976       +2     
  Branches      468      483      +15     
==========================================
- Hits        18977    18966      -11     
+ Misses        529      527       -2     
- Partials      468      483      +15     

see 4 files with indirect coverage changes

@alexanderkiel alexanderkiel added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 3ec5807 Sep 16, 2024
130 checks passed
@alexanderkiel alexanderkiel deleted the with-open-coll branch September 16, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant