Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt Query Params in Page Links #1995

Closed
alexanderkiel opened this issue Aug 28, 2024 · 0 comments · Fixed by #1998
Closed

Encrypt Query Params in Page Links #1995

alexanderkiel opened this issue Aug 28, 2024 · 0 comments · Fixed by #1998
Assignees
Milestone

Comments

@alexanderkiel
Copy link
Member

alexanderkiel commented Aug 28, 2024

Currently, the page links contain the database point in time t of the database state on which the FHIR search query was executed, the query params of the FHIR search and the id of the resource on top of the page. All this information can be manipulated by the client.

Especially, by changing the t the client can access past database states that still contain possibly deleted resources. After we implement #1382, the deleted historic versions of a resource will be no longer accessible in the database state after the delete, but will be still accessible in former database states. That's why it's important that a client can't simply edit the t in page links.

See also: Paging Documentation

@alexanderkiel alexanderkiel self-assigned this Aug 28, 2024
@alexanderkiel alexanderkiel added this to the v0.30.0 milestone Aug 28, 2024
alexanderkiel added a commit that referenced this issue Aug 29, 2024
@alexanderkiel alexanderkiel linked a pull request Aug 29, 2024 that will close this issue
@alexanderkiel alexanderkiel added enhancement New feature or request module:rest-api labels Aug 29, 2024
alexanderkiel added a commit that referenced this issue Sep 4, 2024
alexanderkiel added a commit that referenced this issue Sep 4, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 5, 2024
alexanderkiel added a commit that referenced this issue Sep 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant