This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
Allow injecting the service into Controller constructor for autowiring #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocharsky-bw
suggested changes
Feb 28, 2018
Resources/config/breadcrumbs.xml
Outdated
| @@ -6,11 +6,13 @@ | |||
| <services> | |||
|
|
|||
| <!-- Our service, for controllers --> | |||
| <service id="white_october_breadcrumbs" class="WhiteOctober\BreadcrumbsBundle\Model\Breadcrumbs" public="true"> | |||
| <service id="WhiteOctober\BreadcrumbsBundle\Model\Breadcrumbs" class="WhiteOctober\BreadcrumbsBundle\Model\Breadcrumbs" public="true"> | |||
There was a problem hiding this comment.
Should be private from now
There was a problem hiding this comment.
Makes sense, thanks
Resources/config/breadcrumbs.xml
Outdated
| <call method="setRouter"> | ||
| <argument type="service" id="router" /> | ||
| </call> | ||
| </service> | ||
| <service id="white_october_breadcrumbs" alias="WhiteOctober\BreadcrumbsBundle\Model\Breadcrumbs"> |
|
Ready for merge? |
|
Cool! Can't wait for a point release ;) |
|
For a possible workaround, until it's merged, you can add an alias in your system so you can use it for now: |
|
Thank you for this, @andrewmy. Sorry for the delay in merging. Thank you @bocharsky-bw for reviewing and approving as well - makes my job a lot easier! |
|
This is now in release https://github.com/whiteoctober/BreadcrumbsBundle/releases/tag/1.4.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows injecting the service into Controller constructor for autowiring.