Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

made translation opt out #79

Merged
merged 1 commit into from
May 31, 2017
Merged

Conversation

wickedOne
Copy link
Contributor

fixes #76

Copy link
Owner

@sampart sampart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @wickedOne! Just one minor change requested please.

{% if b.url and not loop.last %}
</a>
<a href="{{ b.url }}" itemprop="item"{% if linkRel is defined and linkRel|length %} rel="{{ linkRel }}"{% endif %}>
{% endif %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tidy up the indentation here please? The if and endif blocks should be at the same level of indentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops...
done

@sampart sampart merged commit a4a7bbc into sampart:master May 31, 2017
@sampart
Copy link
Owner

sampart commented May 31, 2017

Thanks again for this. Let me know if you need a release making.

@wickedOne
Copy link
Contributor Author

you're welcome.
yes a release would be nice, thanks!

@wickedOne wickedOne deleted the optional-translation branch May 31, 2017 09:07
@sampart
Copy link
Owner

sampart commented May 31, 2017

Done: https://github.com/whiteoctober/BreadcrumbsBundle/releases/tag/1.2.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional translation
2 participants