Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back plutovg as a submodule, added option to use system version #208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WerWolv
Copy link
Contributor

@WerWolv WerWolv commented Dec 31, 2024

This PR adds plutovg as a git submodule again and adds the new LUNASVG_USE_SYSTEM_PLUTOVGcmake option to allow using a system-installed version of plutovg instead if needed.

Closes #207

@sammycage
Copy link
Owner

Thanks for the pull request! Why did you choose to use the LUNASVG_USE_SYSTEM_PLUTOVG option?

option(LUNASVG_USE_SYSTEM_PLUTOVG "Use installed version of plutovg instead of bundled submodule" OFF)

if (LUNASVG_USE_SYSTEM_PLUTOVG)
    find_package(plutovg 0.0.4 REQUIRED)
else()
    add_subdirectory(third_party/plutovg)
endif()

Instead of this?

find_package(plutovg 0.0.4 QUIET)
if(NOT plutovg_FOUND)
    add_subdirectory(third_party/plutovg)
endif()

@WerWolv
Copy link
Contributor Author

WerWolv commented Dec 31, 2024

I simply like being explicit. If you rather have it without the extra option, I can remove it

@sammycage
Copy link
Owner

I get the idea of being explicit, but I think removing the LUNASVG_USE_SYSTEM_PLUTOVG option might actually be better. From my experience, users often don’t notice or know about these kinds of options, so they might not even use it. Plus, adding another option just gives users more things to configure, which can make things unnecessarily complicated.

@sammycage
Copy link
Owner

Also, could you move the plutovg submodule from third_party to the root directory since it’s the only dependency?

@WerWolv
Copy link
Contributor Author

WerWolv commented Jan 1, 2025

Implemented both changes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling application with lunasvg isn't possible in many distro package build systems
2 participants