Implement findDescendantNode without cloning the tree

Differential Revision: D49095341 fbshipit-source-id: 2e6244ad73b64ebf387b498d0ab24990f352cc39
sammy-SC · Sep 11, 2023 · aee306c · aee306c
1 parent 03fac82
commit aee306c
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/tests/StateReconciliationTest.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/tests/StateReconciliationTest.cpp
@@ -39,12 +39,18 @@ class DummyShadowTreeDelegate : public ShadowTreeDelegate {
 inline const ShadowNode* findDescendantNode(
     const ShadowNode& shadowNode,
     const ShadowNodeFamily& family) {
-  const ShadowNode* result = nullptr;
-  shadowNode.cloneTree(family, [&](const ShadowNode& oldShadowNode) {
-    result = &oldShadowNode;
-    return oldShadowNode.clone({});
-  });
-  return result;
+  if (&shadowNode.getFamily() == &family) {
+    return &shadowNode;
+  }
+
+  for (auto childNode : shadowNode.getChildren()) {
+    auto descendant = findDescendantNode(*childNode, family);
+    if (descendant != nullptr) {
+      return descendant;
+    }
+  }
+
+  return nullptr;
 }
 
 inline const ShadowNode* findDescendantNode(