Feat/crd print collumns (#32)

* feat: add print collumn for expiry on crd
samirtahir91 · Apr 8, 2024 · 31bbe6b · 31bbe6b
1 parent 8f4dc0f
commit 31bbe6b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/api/v1/githubapp_types.go b/api/v1/githubapp_types.go
@@ -40,6 +40,8 @@ type GithubAppStatus struct {
 //+kubebuilder:subresource:status
 
 // GithubApp is the Schema for the githubapps API
+// +kubebuilder:printcolumn:name="Expires At",type=string,JSONPath=`.status.expiresAt`
+// +kubebuilder:printcolumn:name="Error",type=string,JSONPath=`.status.error`
 type GithubApp struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`

diff --git a/config/crd/bases/githubapp.samir.io_githubapps.yaml b/config/crd/bases/githubapp.samir.io_githubapps.yaml
@@ -14,7 +14,14 @@ spec:
     singular: githubapp
   scope: Namespaced
   versions:
-  - name: v1
+  - additionalPrinterColumns:
+    - jsonPath: .status.expiresAt
+      name: Expires At
+      type: string
+    - jsonPath: .status.error
+      name: Error
+      type: string
+    name: v1
     schema:
       openAPIV3Schema:
         description: GithubApp is the Schema for the githubapps API

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -5,22 +5,22 @@ metadata:
   name: manager-role
 rules:
 - apiGroups:
-  - "apps"
+  - ""
   resources:
-  - deployments
+  - secrets
   verbs:
+  - create
+  - delete
   - get
   - list
   - patch
   - update
   - watch
 - apiGroups:
-  - ""
+  - apps
   resources:
-  - secrets
+  - deployments
   verbs:
-  - create
-  - delete
   - get
   - list
   - patch