Backport to 16.7.x : Add patch for Ruby to fix issue on running on legacy kernel #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkimurak
changed the title
Merged
|
@kkimurak Could you be so kind and fix the merge conflict? (Did I caused the conflict?) |
to allow patching each middleware or library Just move patches to assets/build/patches/gitlabhq Folder name are matched to assets/runtime/config
Backport: fix behavior of `SecureRandom.gen_random_openssl(n)` commit: ruby/ruby@64e503e This has been merged into the Ruby 3.3 release, but Ruby (at least) 3.0 and later are affected by the issues fixed by this commit.
kkimurak
force-pushed
the
ruby-patching_backport16.7.x
branch
from
a25b3c7
to
bee0503
Compare
|
@sachilles Sorry for late, conflictions have been fixed. #2895 modified one of patch and this PR tried to move the patch, conflict occurred then. I should have written a patch so that we could merge them all at once.. |
|
@kkimurak Never mind and (as always) thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is backport of #2897 to 16.7.x branch.
This PR contains following changes:
Currently we can apply some patches only for gitlab itself. This change changes the build patch folder tree and makes it similar to runtime/config, allowing build patches to be applied to both gitlab and ruby.
SecureRandom.gen_random_openssl(n)(See ruby/ruby@64e503e).This commit is originally merged into upstream (Ruby 3.3.x) but can be applied to 3.1.x or later, and neccessary to run it on legacy kernel (For example, the one used by Synology NAS that claims to be able to operate
sameersbn/gitlab)