Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ruby to 3.2.3 #2893

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Update Ruby to 3.2.3 #2893

merged 3 commits into from
Feb 12, 2024

Commits on Jan 30, 2024

  1. Replace removed function in patch for assets::compile 

    `Dir.exists?(file_name) -> bool` have been deprecated since Ruby 2.1
and removed on Ruby 3.2.
See https://bugs.ruby-lang.org/issues/17391

Replacement is `Dir.exist?(file_name) -> bool`.
    @kkimurak
    kkimurak committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9345235 View commit details
    Browse the repository at this point in the history

  2. Remove trailing whitespace in patch for assets:compile 

    to suppress warning on build like below:

    Applying patch /etc/docker-gitlab/build/patches/0004-fix-raketask-gitlab-assets-compile.patch for gitlab-foss...
    <stdin>:15: trailing whitespace.
           removal_targets += Dir.children(Tasks::Gitlab::Assets::PUBLIC_ASSETS_DIR).map {|child| File.join(Tasks::Gitlab::Assets::PUBLIC_ASSETS_DIR, child)}
    warning: 1 line adds whitespace errors.
    @kkimurak
    kkimurak committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1c286f7 View commit details
    Browse the repository at this point in the history

  3. Update Ruby to 3.2.3

    @kkimurak
    kkimurak committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    acabea3 View commit details
    Browse the repository at this point in the history