Upgrade to 12.8.0 #2090
Merged
Upgrade to 12.8.0 #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have anyone tried to build custom image with gitaly server version > 1.83.0? |
|
Yes I did with the same kind of fix than 5efa861 |
|
Symlink # Fix for gitaly-hooks
echo "Linking $(command -v gitaly-hooks) to /"
ln -s "$(command -v gitaly-hooks)" / |
|
hi @solidnerd are there any changes to have this merged ? |
solidnerd
force-pushed
the
upgrade-to-12.8.0
branch
from
d072bf7 to
ebce1f1
Compare
|
Currently with this release it isn‘t possible to run the migrations from a fresh installation. |
|
Hey got anyone of you a clean version with |
|
Here is my current trace of the stack that doesn't come up. Probably @splattael knows something ? |
|
@solidnerd That's odd! I am not sure if it's related but I found some ancient issues describing this problem: https://gitlab.com/gitlab-org/gitlab-foss/-/issues/38947 Are we missing a step? Migration e.g? Just checking 😅 |
|
Any news here? |
|
@solidnerd Can you try this? diff --git a/lib/feature.rb b/lib/feature.rb
index 60a5c03a839..2a89a3e48b3 100644
--- a/lib/feature.rb
+++ b/lib/feature.rb
@@ -33,6 +33,7 @@ class Feature
def persisted_names
return [] unless Gitlab::Database.exists?
+ return [] unless Feature::FlipperFeature.table_exists?
Gitlab::SafeRequestStore[:flipper_persisted_names] ||=
begin |
|
@splattael i can test that, but i don't see that patch in the upstream gitlab. Can you please describe it a bit ? |
|
This one is interesting:https://gitlab.com/gitlab-org/gitlab-development-kit/issues/806 |
|
Hey @splattael and @paolomainardi, |
|
The problem is that this bug doesn't exist on upstream or wasn't reported until now. I'll do this as well. |
|
Thanks a lot @solidnerd, i'm trying if the same bug exist as well on 12.8.2. How safe it is to run this release on a existing database ? |
|
My last test was that I test this change until 12.8.6 or 12.8.7 and the error still occurs . So what I currently see is that there isn't a report on the upstream repository. I think this won't happen on the upgrade way. But If you want to go sure wait for the release by end of the day . I'll also test the upgrade way. |
|
Thanks a lot as always @solidnerd, you rock! |
@paolomainardi Yes, sorry for just dropping the patch without any comment. @solidnerd and I had a quick video call (also) about this issue and found out that this bug won't happen if you follow GitLab's installation guide https://docs.gitlab.com/ee/install/README.html#installation-core-only (omnibus or from source) because they don't expect the database to exist before running I see two options to solve this:
We can try to upstream option 2 otherwise we have to go with option 1 🤷♂️ Thanks @solidnerd for testing the patch 💪 |
|
Okay , I‘ll try to to change the default database in the docker-compose.yml
this will also fix this like you said if this won’t work we will do the
patch.
Peter Leitzen <[email protected]> schrieb am Sa. 28. März 2020 um
20:01:
… @splattael <https://github.com/splattael> i can test that, but i don't
see that patch in the upstream gitlab. Can you please describe it a bit ?
@paolomainardi <https://github.com/paolomainardi> Yes, sorry for just
dropping the patch without any comment.
@solidnerd <https://github.com/solidnerd> and I had a quick video call
(also) about this issue and found out that this bug won't happen if you
follow GitLab's installation guide
https://docs.gitlab.com/ee/install/README.html#installation-core-only
(omnibus or from source) because they don't expect the database to exist
before running rake gitlab:setup. docker-gitlab, however, runs a
container with postgresql which already creates a database on start-up - so
before rake gitlab:setup is run 💥
I see two options to solve this:
1. Don't let postgresql create the database
2. Handle this case in GitLab's code as well
We can try to upstream option 2 otherwise we have to go with option 1 🤷♂
Thanks @solidnerd <https://github.com/solidnerd> for testing the patch 💪
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2090 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGYM35QMDYLKU4LRRBWAL3RJZCO7ANCNFSM4KZYXSYA>
.
|
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
…ed controller name Closes sameersbn#2101 Signed-off-by: solidnerd <[email protected]>
Signed-off-by: solidnerd <[email protected]>
solidnerd
force-pushed
the
upgrade-to-12.8.0
branch
from
6bc82b4 to
5f102ca
Compare
Closed
|
Thanks a lof @splattael for the very detailed explanation. |
|
@solidnerd Upgrade to |
) went smoothly without any issues 👍 Well done and thank you again ❤️
|
@solidnerd Before creating an upstream fix, can you comment on this https://gitlab.com/gitlab-org/gitlab/-/merge_requests/28270? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.