Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #552 #586

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix #552 #586

merged 3 commits into from
Apr 17, 2023

Conversation

LorenzHenk
Copy link
Contributor

Hey, first of all thanks for this nice library 🙏

I hit the same issue that was described in #552 and found a fix (based on https://github.com/danger/danger-js/pull/1313/files#diff-8aba549cc6767419caaf7642d351b16eeebb54be217f6521200c5794b14e1bd3R127).

I've patched the typia library with this exact fix in my project and it now works fine for me.

I've also updated the CONTRIBUTING.md and PULL_REQUEST_TEMPLATE.md to include a command that I also had to run to make tests work.

How to test

  1. create a tsconfig.json file with "moduleResolution": "node"
  2. use that file as --project in the typia cli
  3. everything works as expected now

@samchon samchon changed the base branch from master to features/ts5 April 17, 2023 16:34
@samchon samchon changed the base branch from features/ts5 to master April 17, 2023 16:36
@samchon samchon self-requested a review April 17, 2023 16:46
@samchon samchon self-assigned this Apr 17, 2023
@samchon samchon added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Apr 17, 2023
samchon
samchon approved these changes Apr 17, 2023
View reviewed changes
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it works perfectly.

@samchon samchon merged commit eb4c2b0 into samchon:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samchon samchon samchon approved these changes

Assignees

@samchon samchon

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LorenzHenk @samchon