Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mkdist for esm instead of rollup #1413

Closed
wants to merge 0 commits into from

Conversation

ryoppippi
Copy link
Contributor

This is the patch for build script for mjs.

I experienced and found that

  • cjs issue on randexp is solved in Bun build
  • we don't need to complicated bundler for mjs. just remove types from mjs files and it is fine.
  • keeping structure is important for tree-shaking

So, for this purpose, I picked mkdist, and it works fine in my env.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 58.1 kB pi0
npm/[email protected] shell 0 3.14 kB seb
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] None 0 295 kB rbuckton
npm/[email protected] Transitive: network +4 695 kB samchon
npm/[email protected] None 0 667 kB colinmcd94

View full report↗︎

Copy link

pkg-pr-new bot commented Dec 3, 2024

Open in Stackblitz

npm i https://pkg.pr.new/typia@1413

commit: c5d7a19

@ryoppippi ryoppippi changed the title feat: use mkdist for esm instead of rollup use mkdist for esm instead of rollup Dec 3, 2024
Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the mkdist --dist='lib' -d command, but it is not making the source map files.

@ryoppippi
Copy link
Contributor Author

OK, sourcemap.
I'll investigate it

@ryoppippi
Copy link
Contributor Author

I close this issue and recreate it!

@ryoppippi ryoppippi deleted the feature/mjs branch December 13, 2024 00:56
@ryoppippi ryoppippi restored the feature/mjs branch December 13, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants