Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request body content type bug of SDK library. #987

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Aug 14, 2024

As @nestia/[email protected] generated SDK library always filled request content body type even when request body does not exist. By the phenomenon, it sometimes had caused HTTP request bug in POST/PATCH/PUT/DELETE methoded requests when request body does not exist.

This PR fixes the bug, just by filling the request body's content type only when it is required.

As `@nestia/[email protected]` generated SDK library always had filled request content body type even when request body does not exist, it sometimes had caused HTTP request bug.

This PR fixes the bug, just by filling the request body's content type only when it is required.
@samchon samchon added bug Something isn't working enhancement New feature or request labels Aug 14, 2024
@samchon samchon self-assigned this Aug 14, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nestia/[email protected] filesystem 0 78.9 kB samchon
npm/@nestia/[email protected] filesystem 0 131 kB samchon
npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, unsafe +23 814 kB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, unsafe +60 8.07 MB nestjscore
npm/@trivago/[email protected] Transitive: environment +35 8.35 MB behraang
npm/@types/[email protected] None 0 13.1 kB types
npm/@types/[email protected] None +4 34.6 kB types
npm/[email protected] None 0 62.2 kB andidittrich
npm/[email protected] environment, filesystem, shell 0 174 kB shadowspawn
npm/[email protected] None 0 13.9 kB motdotla
npm/[email protected] environment, filesystem, network Transitive: eval, unsafe +45 1.3 MB wesleytodd
npm/[email protected] None 0 87.6 kB sboudrias
npm/[email protected] environment, filesystem +5 2.83 MB isaacs
npm/[email protected] None +1 27.6 kB sindresorhus
npm/[email protected] Transitive: environment, filesystem, shell +6 1.26 MB flosse
npm/[email protected] filesystem +1 890 kB linusu
npm/[email protected] None +1 11.3 MB scottie1984

🚮 Removed packages: npm/@fastify/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem more.

@samchon samchon merged commit c7d95f6 into master Aug 14, 2024
6 checks passed
@samchon samchon deleted the feature/type branch August 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant