Complement #652 - fix bug of SDK distrubition composer. #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've banned `yarn berry` which does not support `npm prepare` command to change setup wizard to using the standard `npm prepare` command. By the way, SDK distribution composer had determined whether the target distribution directory has been prepared by checking the `package.json` file with the `npm run prepare` command. Therefore, if the SDK distrubition directory being composed by older version of `@nestia/sdk`, newer version's SDK distribution composer re-composed the distribution directory vulnerably. This PR fixes such bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've banned
yarn berrywhich does not supportnpm preparecommand to change setup wizard to using the standardnpm preparecommand.By the way, SDK distribution composer had determined whether the target distribution directory has been prepared by checking the
package.jsonfile with thenpm run preparecommand.Therefore, if the SDK distrubition directory being composed by older version of
@nestia/sdk, newer version's SDK distribution composer re-composed the distribution directory vulnerably.This PR fixes such bug.