-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo setup and fix some inteded bug cases. #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchon
commented
Dec 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is prepared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the build and deployment workflows, as well as changes to the package dependencies to use workspace references. The most important changes include adding a new release workflow, updating existing workflows to use
pnpm
for dependency management, and refactoring deployment scripts for better modularity and maintainability.Workflow Updates:
.github/workflows/release.yml
: Added a new release workflow to automate the publishing process when a release is created..github/workflows/build.yml
&.github/workflows/migrate.yaml
: Updated to usepnpm
for installing dependencies and adjusted paths for testing scripts. [1] [2].github/workflows/website.yml
: Replacednpm
withpnpm
for dependency installation and build process.Dependency Management:
package.json
files across various packages: Updated to useworkspace:^
for internal package dependencies, ensuring consistent versions across the monorepo. [1] [2] [3] [4] [5] [6] [7] [8]Deployment Script Refactoring:
deploy/build.js
: Introduced a new build script to handle the build process for multiple packages in a modular way.deploy/index.js
: Refactored to add a main function that can handle both build and publish commands.deploy/publish.js
: Refactored to include a build step before publishing and improved the setup and deploy functions for better readability and maintainability. [1] [2] [3] [4]Miscellaneous:
build/index.js
script, which was responsible for building and testing all packages. This functionality has been moved to the new modular scripts.package.json
scripts to use the new deployment commands. [1] [2]