Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement #941: finalize TypedFormData() to support fastify-multer. #1116

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

samchon
Copy link
Owner

@samchon samchon commented Nov 27, 2024

This pull request includes several updates to dependencies and refactors the handling of multipart form data in the packages/core module. The most important changes include updating package.json files, replacing the fastify-multipart library with fastify-multer, and modifying the TypedFormData decorator to support the new library.

Dependency Updates:

  • Updated the version of @nestia/station in package.json from 4.0.0-dev.20241027 to 4.0.0-dev.20241027-2.
  • Added @types/multer and fastify-multer dependencies in packages/core/package.json.
  • Updated the version constraint for typia in packages/core/package.json to >=7.0.0-dev.20241027-2 <8.0.0.
  • Removed @fastify/multipart from devDependencies and updated fastify to ^4.28.1 in packages/core/package.json.

Refactoring TypedFormData:

  • Replaced multer with fastify-multer in TypedFormData decorator and updated related imports and documentation. [1] [2] [3] [4]
  • Modified the Body function to accept options for multer or fastify-multer. [1] [2]
  • Updated the decodeExpress and decodeFastify functions to use the new fastify-multer library. [1] [2]
  • Removed the multerApplication singleton and updated the multipart form data parsing logic.

Test Updates:

  • Replaced @fastify/multipart with fastify-multer in the test/features/multipart-form-data-fastify/src/Backend.ts file. [1] [2]
  • Added fastify-multer dependency in test/package.json.

@samchon samchon added the enhancement New feature or request label Nov 27, 2024
@samchon samchon self-assigned this Nov 27, 2024
Copy link

socket-security bot commented Nov 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@trivago/[email protected] Transitive: environment +30 9.88 MB behraang
npm/[email protected] environment, filesystem +3 1.21 MB isaacs
npm/[email protected] Transitive: environment, filesystem, shell +6 1.26 MB flosse
npm/[email protected] None 0 146 kB danielpza

🚮 Removed packages: npm/@nestia/[email protected], npm/[email protected]

View full report↗︎

@samchon
Copy link
Owner Author

samchon commented Nov 27, 2024

@sergio-milu Check and review how it has been changed please.

Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works propertly.

@samchon samchon merged commit f33a5c0 into v4.0 Nov 27, 2024
5 checks passed
@samchon samchon deleted the feat/multer branch November 27, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants