Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1014: OpenApi.IOperation.IResponse[key].description to be required. #1015

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix #1014: OpenApi.IOperation.IResponse[key].description to be required. #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@nestia/station",
"version": "3.12.1",
"version": "3.12.2",
"description": "Nestia station",
"scripts": {
"build": "node build/index.js",
Expand Down
8 changes: 4 additions & 4 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nestia/core",
"version": "3.12.1",
"version": "3.12.2",
"description": "Super-fast validation decorators of NestJS",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down Expand Up @@ -36,7 +36,7 @@
},
"homepage": "https://nestia.io",
"dependencies": {
"@nestia/fetcher": "^3.12.1",
"@nestia/fetcher": "../fetcher/nestia-fetcher-3.12.2.tgz",
"@nestjs/common": ">=7.0.1",
"@nestjs/core": ">=7.0.1",
"@samchon/openapi": "^0.4.6",
Expand All @@ -49,11 +49,11 @@
"reflect-metadata": ">=0.1.12",
"rxjs": ">=6.0.3",
"tgrid": "^1.0.0",
"typia": "^6.9.0",
"typia": ">=6.9.0 <7.0.0",
"ws": "^7.5.3"
},
"peerDependencies": {
"@nestia/fetcher": ">=3.12.1",
"@nestia/fetcher": ">=3.12.2",
"@nestjs/common": ">=7.0.1",
"@nestjs/core": ">=7.0.1",
"reflect-metadata": ">=0.1.12",
Expand Down
2 changes: 1 addition & 1 deletion packages/fetcher/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nestia/fetcher",
"version": "3.12.1",
"version": "3.12.2",
"description": "Fetcher library of Nestia SDK",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down
10 changes: 5 additions & 5 deletions packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nestia/sdk",
"version": "3.12.1",
"version": "3.12.2",
"description": "Nestia SDK and Swagger generator",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand Down Expand Up @@ -32,8 +32,8 @@
},
"homepage": "https://nestia.io",
"dependencies": {
"@nestia/core": "^3.12.1",
"@nestia/fetcher": "^3.12.1",
"@nestia/core": "../core/nestia-core-3.12.2.tgz",
"@nestia/fetcher": "../fetcher/nestia-fetcher-3.12.2.tgz",
"@samchon/openapi": "^0.4.6",
"@wrtnio/openai-function-schema": "^0.2.3",
"cli": "^1.0.1",
Expand All @@ -48,8 +48,8 @@
"typia": "^6.9.0"
},
"peerDependencies": {
"@nestia/core": ">=3.12.1",
"@nestia/fetcher": ">=3.12.1",
"@nestia/core": ">=3.12.2",
"@nestia/fetcher": ">=3.12.2",
"@nestjs/common": ">=7.0.1",
"@nestjs/core": ">=7.0.1",
"reflect-metadata": ">=0.1.12",
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/src/generates/internal/SwaggerOperationResponseComposer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export namespace SwaggerOperationResponseComposer {
oldbie.description ??= description;
else if (oldbie === undefined)
output[status] = {
description,
description: description,
content: {
"application/json": {
schema: {},
Expand All @@ -76,7 +76,7 @@ export namespace SwaggerOperationResponseComposer {
] = {
description: props.route.success.encrypted
? `${warning.get(!!description, props.route.method)}${description ?? ""}`
: description,
: (description ?? ""),
content: props.route.success.contentType
? {
[props.route.success.contentType]: {
Expand Down
4 changes: 3 additions & 1 deletion test/features/all/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}
],
"info": {
"version": "3.12.1-dev.20240903",
"version": "3.12.2",
"title": "@samchon/nestia-test",
"description": "Test program of Nestia",
"license": {
Expand Down Expand Up @@ -52,6 +52,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {}
}
Expand All @@ -65,6 +66,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down
26 changes: 25 additions & 1 deletion test/features/app-globalPrefix-versionUri-routerModule/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}
],
"info": {
"version": "3.12.1-dev.20240903",
"version": "3.12.2",
"title": "@samchon/nestia-test",
"description": "Test program of Nestia",
"license": {
Expand All @@ -21,6 +21,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {}
}
Expand All @@ -34,6 +35,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {}
}
Expand All @@ -47,6 +49,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {}
}
Expand All @@ -60,6 +63,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand All @@ -77,6 +81,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand All @@ -94,6 +99,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -150,6 +156,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -245,6 +252,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -340,6 +348,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -414,6 +423,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -498,6 +508,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -582,6 +593,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -696,6 +708,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -739,6 +752,7 @@
},
"responses": {
"201": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -804,6 +818,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -847,6 +862,7 @@
},
"responses": {
"201": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -912,6 +928,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -955,6 +972,7 @@
},
"responses": {
"201": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -999,6 +1017,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -1051,6 +1070,7 @@
},
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -1095,6 +1115,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -1147,6 +1168,7 @@
},
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -1191,6 +1213,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -1243,6 +1266,7 @@
},
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down
8 changes: 7 additions & 1 deletion test/features/app-globalPrefix-versionUri/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}
],
"info": {
"version": "3.12.1-dev.20240903",
"version": "3.12.2",
"title": "@samchon/nestia-test",
"description": "Test program of Nestia",
"license": {
Expand All @@ -21,6 +21,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {}
}
Expand All @@ -34,6 +35,7 @@
"parameters": [],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -90,6 +92,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -146,6 +149,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -202,6 +206,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down Expand Up @@ -276,6 +281,7 @@
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
Expand Down
Loading