This repository has been archived by the owner on Nov 15, 2020. It is now read-only.
Support sprintf-style stream names #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which was incorrectly anticipating that the leading hyphen would no longer be preprended when using the newer API that has event.set
|
Aww yeah. This is sweet. And you even contributed more tests! You're a legend! |
samcday
added a commit
that referenced
this pull request
Sep 2, 2017
Support sprintf-style stream names Former-commit-id: e241b19
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the Kinesis stream name to be dynamic based on the event. This implementation was modeled off Kafka's topic selection, IIRC (I implemented this a long time ago and we've actually been running it for several months).
In our case this allowed us to go from 10 kinesis outputs for 10 streams to 1.
Example config: this will convert the stream name based on the
resource_typefield in each event.