Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto extract trace and span info from context #25

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

morigs
Copy link
Contributor

@morigs morigs commented Oct 4, 2024

Now when using WithContext the OpenTelemetry TraceID and SpanID will be automatically extracted and save in trace and span properties. This commit also fixes tests for working in forks (with different repo owner name).

Somewhat partially resolves #10

morigs and others added 3 commits October 4, 2024 09:53
Now when using WithContext the OpenTelemetry TraceID and SpanID will be
automatically extracted and save in trace and span properties.
This commit also fixes tests for working in forks (with different repo
owner name).
- downgrading otel to 1.29 to keep the backward compatibility with go 1.21
- upgrading some deps
- removing golang.org/x/exp
@samber
Copy link
Owner

samber commented Nov 4, 2024

Thanks for this first contrib!

some fixes:

  • downgrading otel to 1.29 to keep the backward compatibility with go 1.21
  • upgrading some deps
  • removing golang.org/x/exp
  • moving debug.ReadBuildInfo() at the top of the file to prevent useless processing

@samber samber merged commit ad72a71 into samber:main Nov 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with OTEL
2 participants