Option: Support omitempty #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires changing the underlying type, which *may* be a breaking change.
AFAICT there isn't any way to do this with the struct based type, but can
be done with a slice type (or a map, but maps are heavier weight, so chose slice).
When the slice is empty (len == 0) it is considered absent, when it has an item
it is considered present.
This also allows for creating a value via:
`Option[T]{value}`
Any values appended to the slice after the first are ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires changing the underlying type, which may be a breaking change.
AFAICT there isn't any way to do this with the struct based type, but can be done with a slice type (or a map, but maps are heavier weight, so chose slice).
When the slice is empty (len == 0) it is considered absent, when it has an item it is considered present.
This also allows for creating a value via:
Option[T]{value}Any values appended to the slice after the first are ignored.