Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move general functionality to the outside package #1 #2

Merged
merged 2 commits into from
Feb 1, 2022
Merged

feat: move general functionality to the outside package #1 #2

merged 2 commits into from
Feb 1, 2022

Conversation

iliawx
Copy link
Collaborator

@iliawx iliawx commented Jan 31, 2022

Closes #1

@iliawx iliawx self-assigned this Jan 31, 2022
sampullman
sampullman requested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@sampullman sampullman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of notes on app-specific things that shouldn't be included, otherwise looks pretty good!

lib/type/i-flow-purchase-event.ts Outdated Show resolved Hide resolved
lib/util/parse-cadence-events.spec.ts Outdated Show resolved Hide resolved
lib/util/parse-cadence-events.ts Outdated Show resolved Hide resolved
iliawx
iliawx commented Feb 1, 2022
View reviewed changes
Copy link
Collaborator Author

@iliawx iliawx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the app-specific IFlowPurchaseEvent interface and consolidated misc flow functions.

@sampullman sampullman force-pushed the 1-move-general-functions-to-package branch from 9e8a948 to 24b1694 Compare February 1, 2022 07:14
@sampullman sampullman merged commit 5c382c2 into main Feb 1, 2022
@iliawx iliawx deleted the 1-move-general-functions-to-package branch March 25, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampullman sampullman Awaiting requested review from sampullman

Assignees

@iliawx iliawx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move general functions from the main app
3 participants
@iliawx @sampullman @inazarov