add python3 extra toolchain

samansmink · Oct 13, 2024 · 092fec5 · 092fec5
1 parent 2a4472d
commit 092fec5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.github/workflows/MainDistributionPipeline.yml b/.github/workflows/MainDistributionPipeline.yml
@@ -27,7 +27,7 @@ jobs:
       duckdb_version: v1.1.1
       ci_tools_version: main
       extension_name: rusty_quack
-      extra_toolchains: rust
+      extra_toolchains: rust;python3
       matrix_parse_script: "./extension-ci-tools/scripts/modify_distribution_matrix.py"
       exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads;windows_amd64_rtools;windows_amd64'
 

diff --git a/Makefile b/Makefile
@@ -18,8 +18,17 @@ ifneq ($(EXPLICIT_EXTENSION_VERSION),)
 	EXTENSION_VERSION = $(EXPLICIT_EXTENSION_VERSION)
 endif
 
-# TODO make platform independent
 EXTENSION_LIB_FILENAME=lib$(EXTENSION_NAME).dylib
+ifeq ($(UNAME_S),Linux)
+	EXTENSION_LIB_FILENAME=lib$(EXTENSION_NAME).so
+endif
+ifeq ($(UNAME_S),Darwin)
+	EXTENSION_LIB_FILENAME=lib$(EXTENSION_NAME).dylib
+endif
+ifeq ($(OS),Windows_NT)
+	# TODO: how/what/where
+	EXTENSION_LIB_FILENAME=lib$(EXTENSION_NAME).dylib
+endif
 EXTENSION_FILENAME=$(EXTENSION_NAME).duckdb_extension
 
 ### Development options

diff --git a/extension-ci-tools b/extension-ci-tools