feature/form-filling-scenario-params-masking: #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mikhail-Gl96
commented
Oct 26, 2023
Mikhail-Gl96
commented
- add masking for logging data_extracted_str
- add masking for logging data_extracted_str
DimaProskurin
requested changes
Oct 26, 2023
| @lru_cache | ||
| def _get_common_masking_fields(user) -> list: | ||
| """Get global masking fields from user settings from file with name template_settings.""" | ||
| return user.settings['template_settings'].get('masking_fields', []) if user is not None else [] |
There was a problem hiding this comment.
двойные кавычки пожалуйста
| @@ -174,14 +176,25 @@ async def get_reply(self, user, text_preprocessing_result, reply_actions, field, | |||
| user.last_scenarios.delete(self.id) | |||
| return action_messages | |||
|
|
|||
| @staticmethod | |||
| @lru_cache | |||
| def _get_common_masking_fields(user) -> list: | |||
There was a problem hiding this comment.
return type - словарь
masking_fields в template_config словарь
| @lru_cache | ||
| def _get_common_masking_fields(user) -> list: | ||
| """Get global masking fields from user settings from file with name template_settings.""" | ||
| return user.settings['template_settings'].get('masking_fields', []) if user is not None else [] |
There was a problem hiding this comment.
дефолтное значение - словарь
| def _get_masked_params(self, data: dict, user) -> dict: | ||
| """Masking data by global masking fields.""" | ||
| masking_fields = self._get_common_masking_fields(user) | ||
| return masking(data=deepcopy(data), masking_fields=masking_fields) |
There was a problem hiding this comment.
masking не меняет передаваемый объект, поэтому deepcopy не нужен
- review fixes
DimaProskurin
approved these changes
Oct 26, 2023
DimaProskurin
pushed a commit
that referenced
this pull request
Nov 8, 2023
* feature/form-filling-scenario-params-masking: - add masking for logging data_extracted_str * feature/form-filling-scenario-params-masking: - review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.