Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plasma-new-hope): Fix size for Spinner component #966

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix(plasma-new-hope): Fix size for Spinner component #966

merged 1 commit into from
Jan 17, 2024

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Jan 16, 2024 •
edited by Salute-Eva
Loading

Spinner

Исправлено отображение компонента Spinner при размере 8px

What/why changed

Если указать значение size='8' у компонента Spinner, то он будет крутиться не во круг своей оси, а со смещением

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-966/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-966/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-966/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-966/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-966/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-966/asdk-storybook/

@neretin-trike neretin-trike added this pull request to the merge queue Jan 17, 2024
Merged via the queue into dev with commit ef74612 Jan 17, 2024
25 checks passed
@neretin-trike neretin-trike deleted the neretinaa/fix-spinner-sizes branch January 17, 2024 06:03
This was referenced Jan 18, 2024
Closed
Closed
Closed
@Yakutoc Yakutoc mentioned this pull request Jan 18, 2024
Merged
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees
No one assigned
Labels
plasma-components released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@neretin-trike @Salute-Eva @Yeti-or @Yakutoc @TitanKuzmich @kayman233