Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope/web/b2c): Counter component #965

Merged
merged 5 commits into from
Jan 17, 2024
Merged

feat(plasma-new-hope/web/b2c): Counter component #965

merged 5 commits into from
Jan 17, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jan 15, 2024 •
edited by Salute-Eva
Loading

Counter

  • добавлен компонент Counter в new-hope
  • Counter добавлен в поставку b2c/web
  • написаны тесты и документация

What/why changed

Добавлен компонент Counter в новой архитектуре.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Jan 15, 2024
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-965/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-965/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-965/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-965/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-965/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-965/asdk-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2338/counter-refactor-redesign branch from 03e625c to 2038a36 Compare January 16, 2024 13:56
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-965/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-965/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-965/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-965/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-965/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-965/asdk-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-2338/counter-refactor-redesign branch from 2038a36 to dbdd4e6 Compare January 17, 2024 07:23
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-965/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-965/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-965/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-965/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-965/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-965/asdk-storybook/

@TitanKuzmich TitanKuzmich force-pushed the plasma-2338/counter-refactor-redesign branch from 786de10 to 476a083 Compare January 17, 2024 19:29
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-965/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-965/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-965/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-965/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-965/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-965/asdk-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jan 17, 2024
Merged via the queue into dev with commit 151fdfd Jan 17, 2024
25 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-2338/counter-refactor-redesign branch January 17, 2024 20:07
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

2 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

This was referenced Jan 18, 2024
Closed
Closed
Closed
@Yakutoc Yakutoc mentioned this pull request Jan 18, 2024
Merged
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components released
Projects
Plasma
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Salute-Eva @neretin-trike @kayman233