Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-b2c/web): add skeleton new typography sizes #960

Merged
merged 4 commits into from
Jan 12, 2024
Merged

feat(plasma-b2c/web): add skeleton new typography sizes #960

merged 4 commits into from
Jan 12, 2024

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jan 9, 2024 •
edited by Salute-Eva
Loading

Skeleton

  • добавлены размеры скелетона под новую типографику

What/why changed

Добавлена поддержка размеров новой типографики, так как в будущем будем уходить от старой

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Jan 9, 2024
@TitanKuzmich TitanKuzmich removed the request for review from Yakutoc January 9, 2024 08:20
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-960/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-960/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-960/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-960/web-storybook/

@TitanKuzmich TitanKuzmich force-pushed the plasma-1964/add-skeleton-new-typography-sizes branch from 68d23d3 to e6f4a36 Compare January 9, 2024 08:44
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-960/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-960/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-960/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-960/web-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-960/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-960/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-960/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-960/web-storybook/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-1964/add-skeleton-new-typography-sizes branch from 2626d17 to b0b1a33 Compare January 9, 2024 09:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich force-pushed the plasma-1964/add-skeleton-new-typography-sizes branch from b0b1a33 to f37f13f Compare January 10, 2024 07:47
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-960/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-960/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-960/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-960/web-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jan 12, 2024
Merged via the queue into dev with commit 6068a90 Jan 12, 2024
25 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma-1964/add-skeleton-new-typography-sizes branch January 12, 2024 12:08
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

2 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

This was referenced Jan 18, 2024
Closed
Closed
Closed
@Yakutoc Yakutoc mentioned this pull request Jan 18, 2024
Merged
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

@neretin-trike neretin-trike Awaiting requested review from neretin-trike neretin-trike is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
plasma-components released
Projects
Plasma
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Salute-Eva @Yeti-or @kayman233