Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plasma-new-hope): fix CalendarDouble ref #959

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat(plasma-new-hope): fix CalendarDouble ref #959

merged 1 commit into from
Dec 28, 2023

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Dec 28, 2023 •
edited by Salute-Eva
Loading

Calendar

  • добавлен ref в forwardRef вторым аргументом

What/why changed

В CalendarDouble в forwardRef не было ref как пропса, из-за чего в консоль падал ворнинг об этом.
forwardRef должен принимать два аргумента

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich added the bugs Something isn't working label Dec 28, 2023
@TitanKuzmich TitanKuzmich self-assigned this Dec 28, 2023
@TitanKuzmich TitanKuzmich mentioned this pull request Dec 28, 2023
Merged
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-959/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-959/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-959/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-959/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-959/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-959/asdk-storybook/

@Yeti-or
Copy link
Contributor

Yeti-or commented Dec 28, 2023 

добавлен ref в forwardRef вторым аргументом

чет не ясное описание как мне кажется
напиши что именно это правит и зачем

@TitanKuzmich
Copy link
Contributor Author 

добавлен ref в forwardRef вторым аргументом

чет не ясное описание как мне кажется напиши что именно это правит и зачем

Поправил описание

@TitanKuzmich TitanKuzmich force-pushed the plasma/fix-calendar-ref-pass branch from 7384d64 to 848d2a2 Compare December 28, 2023 11:40
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-959/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-959/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-959/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-959/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-959/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-959/asdk-storybook/

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Dec 28, 2023
Merged via the queue into dev with commit b588194 Dec 28, 2023
25 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma/fix-calendar-ref-pass branch December 28, 2023 12:00
This was referenced Jan 18, 2024
Closed
Closed
Closed
@Yakutoc Yakutoc mentioned this pull request Jan 18, 2024
Merged
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@Yeti-or Yeti-or Yeti-or approved these changes

Assignees

@TitanKuzmich TitanKuzmich

Labels
bugs Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Salute-Eva @Yeti-or @kayman233