Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hot-fix(plasma-new-hope): redefining classnames for typography #951

Merged
merged 8 commits into from
Dec 25, 2023
Merged

hot-fix(plasma-new-hope): redefining classnames for typography #951

merged 8 commits into from
Dec 25, 2023

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Dec 25, 2023 •
edited by Salute-Eva
Loading

Typography

  • root для типографики вынесен в общий компонент
  • className, style теперь явно задаются в компоненте
  • исправлены конфиги для asdk поставки

What/why changed

Если типографику обернуть в styled из styled-components, слетали классы и инлайн-стили. Теперь className, style достаются как пропсы и складываются в соответствующие атрибуты

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-951/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-951/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-951/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-951/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-951/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-951/asdk-storybook/

@TitanKuzmich TitanKuzmich force-pushed the plasma/typography-hot-fix branch from 82c6332 to e64aa57 Compare December 25, 2023 13:14
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-951/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-951/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-951/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-951/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-951/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-951/asdk-storybook/

@TitanKuzmich TitanKuzmich force-pushed the plasma/typography-hot-fix branch from e64aa57 to d92c6b5 Compare December 25, 2023 13:51
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-951/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-951/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-951/b2c-storybook/
web storybook: http://plasma.sberdevices.ru/pr/pr-951/web-storybook/
new-hope storybook: http://plasma.sberdevices.ru/pr/pr-951/new-hope-storybook/
asdk storybook: http://plasma.sberdevices.ru/pr/pr-951/asdk-storybook/

@github-actions GitHub Actions
Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Dec 25, 2023
Merged via the queue into master with commit da194af Dec 25, 2023
25 checks passed
@TitanKuzmich TitanKuzmich deleted the plasma/typography-hot-fix branch December 25, 2023 15:27
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayman233 kayman233 kayman233 approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

@Yeti-or Yeti-or Awaiting requested review from Yeti-or Yeti-or is a code owner

@Yakutoc Yakutoc Awaiting requested review from Yakutoc Yakutoc is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TitanKuzmich @Salute-Eva @neretin-trike @kayman233